Skip to content

Invalid version found by pip for flit install -s packages #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivirshup opened this issue Mar 1, 2021 · 2 comments · Fixed by #395
Closed

Invalid version found by pip for flit install -s packages #394

ivirshup opened this issue Mar 1, 2021 · 2 comments · Fixed by #395

Comments

@ivirshup
Copy link

ivirshup commented Mar 1, 2021

flit symlinked installed packages with build numbers are being overwritten with versions from pypi if any package that depends on it are installed. Here's an example:

conda create -yn flit-deps python=3.8 flit
conda activate flit-deps
gh repo clone theislab/scanpy
cd scanpy
gh pr checkout 1527  # The PR that uses flit
flit install -s --deps=develop

cd ~  # Move out of the directory

python -c "import scanpy; print(scanpy.__version__)"
# 1.8.0.dev50+g8e703b89.d20210301 

pip install scvelo  # Package that depends on scanpy. Truncated output:
# ...
# Collecting scanpy>=1.5
#  Using cached scanpy-1.7.1-py3-none-any.whl (10.3 MB)
# ...
#  Attempting uninstall: scanpy
#    Found existing installation: scanpy 1.8.0.dev50-g8e703b89.d20210301
#    Uninstalling scanpy-1.8.0.dev50-g8e703b89.d20210301:
#      Successfully uninstalled scanpy-1.8.0.dev50-g8e703b89.d20210301

python3 -c "import scanpy; print(scanpy.__version__)"
# 1.7.1

It looks to me like pip is getting incorrect version information about the package, similar to the problem raised in #383 and addressed in #388. However, in this case the package is not a wheel.

@flying-sheep
Copy link
Contributor

Might also be a pip problem: pypa/pip#9670

@flying-sheep
Copy link
Contributor

Fixed! See the check here: scverse/scanpy#1702 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants