Rename InstallationCandidate.{project -> name}

Author: pradyunsg

src/pip/_internal/index/package_finder.py

@@ -758,7 +758,7 @@ def get_install_candidate(self, link_evaluator, link):
             return None
 
         return InstallationCandidate(
-            project=link_evaluator.project_name,
+            name=link_evaluator.project_name,
             link=link,
             # Convert the Text result to str since InstallationCandidate
             # accepts str.

src/pip/_internal/models/candidate.py

@@ -9,31 +9,33 @@
 if MYPY_CHECK_RUNNING:
     from pip._vendor.packaging.version import _BaseVersion
     from pip._internal.models.link import Link
-    from typing import Any
 
 
 class InstallationCandidate(KeyBasedCompareMixin):
     """Represents a potential "candidate" for installation.
     """
 
-    def __init__(self, project, version, link):
-        # type: (Any, str, Link) -> None
-        self.project = project
+    def __init__(self, name, version, link):
+        # type: (str, str, Link) -> None
+        self.name = name
         self.version = parse_version(version)  # type: _BaseVersion
         self.link = link
 
+        self.already_installed = False
+        self.editable = False
+
         super(InstallationCandidate, self).__init__(
-            key=(self.project, self.version, self.link),
+            key=(self.name, self.version, self.link),
             defining_class=InstallationCandidate
         )
 
     def __repr__(self):
         # type: () -> str
         return "<InstallationCandidate({!r}, {!r}, {!r})>".format(
-            self.project, self.version, self.link,
+            self.name, self.version, self.link,
         )
 
     def __str__(self):
         return '{!r} candidate (version {} at {})'.format(
-            self.project, self.version, self.link,
+            self.name, self.version, self.link,
         )

tests/unit/test_models.py

@@ -47,7 +47,7 @@ def test_sets_correct_variables(self):
         obj = candidate.InstallationCandidate(
             "A", "1.0.0", "https://somewhere.com/path/A-1.0.0.tar.gz"
         )
-        assert obj.project == "A"
+        assert obj.name == "A"
         assert obj.version == parse_version("1.0.0")
         assert obj.link == "https://somewhere.com/path/A-1.0.0.tar.gz"
 
@@ -57,4 +57,4 @@ def test_sets_the_right_key(self):
         obj = candidate.InstallationCandidate(
             "A", "1.0.0", "https://somewhere.com/path/A-1.0.0.tar.gz"
         )
-        assert obj._compare_key == (obj.project, obj.version, obj.link)
+        assert obj._compare_key == (obj.name, obj.version, obj.link)