Merge pull request #10697 from jiunbae/main

pradyunsg · web-flow · commit d35bedc5cbb9 · 2022-02-19T11:50:41.000Z
Resolves junction links when deleting packages installed as editable
diff --git a/news/10696.bugfix.rst b/news/10696.bugfix.rst
@@ -0,0 +1 @@
+Fix uninstall editable from Windows junction link.
diff --git a/src/pip/_internal/req/req_uninstall.py b/src/pip/_internal/req/req_uninstall.py
@@ -527,7 +527,7 @@ def from_dist(cls, dist: BaseDistribution) -> "UninstallPathSet":
             # above, so this only covers the setuptools-style editable.
             with open(develop_egg_link) as fh:
                 link_pointer = os.path.normcase(fh.readline().strip())
-            assert link_pointer == dist_location, (
+            assert os.path.samefile(link_pointer, dist_location), (
                 f"Egg-link {link_pointer} does not match installed location of "
                 f"{dist.raw_name} (at {dist_location})"
             )

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix uninstall editable from Windows junction link.`
Original file line number	Diff line number	Diff line change
`@@ -527,7 +527,7 @@ def from_dist(cls, dist: BaseDistribution) -> "UninstallPathSet":`
`527`	`527`	`# above, so this only covers the setuptools-style editable.`
`528`	`528`	`with open(develop_egg_link) as fh:`
`529`	`529`	`link_pointer = os.path.normcase(fh.readline().strip())`
`530`		`- assert link_pointer == dist_location, (`
	`530`	`+ assert os.path.samefile(link_pointer, dist_location), (`
`531`	`531`	`f"Egg-link {link_pointer} does not match installed location of "`
`532`	`532`	`f"{dist.raw_name} (at {dist_location})"`
`533`	`533`	`)`