Skip to content

Commit f1922cc

Browse files
committed
Remove error handler around find_all_candidates to see if it fails in github actions ci
Run black over tests/unit/test_finder.py
1 parent 1015e6c commit f1922cc

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

src/pip/_internal/resolution/resolvelib/resolver.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -172,15 +172,8 @@ def _prime_finder_cache(self, project_names: Iterable[str]) -> None:
172172
in parallel in order to avoid later blocking on network requests during
173173
resolution.
174174
"""
175-
176-
def _maybe_find_candidates(project_name: str) -> None:
177-
try:
178-
self._finder.find_all_candidates(project_name)
179-
except AttributeError:
180-
pass
181-
182175
with ThreadPool() as tp:
183-
for _ in tp.imap_unordered(_maybe_find_candidates, project_names):
176+
for _ in tp.imap_unordered(self._finder.find_all_candidates, project_names):
184177
pass
185178

186179
def get_installation_order(

tests/unit/test_finder.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,6 @@ def test_find_all_candidates_find_links_and_index(data: TestData) -> None:
569569

570570

571571
def test_finder_caching(data: TestData) -> None:
572-
573572
# This is not required for the behavior of the finder itself, but we exploit
574573
# the implementation of the finder's find_best_candidate consuming it's own
575574
# find_all_candidates cache to pre-populate the cache before the resolution process

0 commit comments

Comments
 (0)