Skip to content

for VCS install targets, check the parameters after "#" for typos (egg, subdirectory) #11878

Description

@szabi

What's the problem this feature will solve?

In reference to Issue #11854, and @uranusjr 's comment, check the two pip-specific virtual GET parameters for typos.

Those typos can be hard to catch, and the error resulting from them is not straightforward.

Describe the solution you'd like

If a VCS URL has parameters (#...&...), check that only the valid parameters "egg" and "subdirectory" are present.

If an other parameter is present, report an error.

pseudocode:

if not all([p in ('egg', 'subdirectory') for p in GET_PARAMETER_NAMES]):
    throw Error

The particular usecase is to guard against typos, e.g. a user writing #egg_info=... instead of #egg=... or a hard-to-catch typo, such as in #11854, #subdiretory=... instead of #subdirectory=....

Alternative Solutions

The alternative is that the user does not make typos... but that's not very service-oriented.

Additional context

As mentioned, #11854.

Code of Conduct

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions