Skip to content

--upgrade-strategy unmentioned in Release Notes #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gotgenes opened this issue Apr 4, 2017 · 3 comments · Fixed by #4542
Closed

--upgrade-strategy unmentioned in Release Notes #4418

gotgenes opened this issue Apr 4, 2017 · 3 comments · Fixed by #4542
Labels
auto-locked Outdated issues that have been locked by automation good first issue A good item for first time contributors to work on type: docs Documentation related

Comments

@gotgenes
Copy link

gotgenes commented Apr 4, 2017 •
edited
Loading

  • Pip version: 9.0.1
  • Python version: CPython 3.6
  • Operating system: All

--upgrade-strategy is not mentioned in the Release Notes, a.k.a., NEWS.rst. It should have been documented. It was merged in for #3972, somewhat documented in #4232, and released into production, but never announced in the Release Notes. This should be retroactively documented.

I would recommend noting in the release notes what the default value for this new option is, too.
@gotgenes gotgenes changed the title --upgrade-strategy completely unmentioned in Release Notes --upgrade-strategy unmentioned in Release Notes Apr 4, 2017
@xavfernandez xavfernandez added type: docs Documentation related good first issue A good item for first time contributors to work on labels Apr 7, 2017
@pradyunsg
Copy link
Member

@gotgenes Thanks for spotting that!

@xavfernandez Would adding a news/3972.feature be enough for this? Is there something more needed?

@pradyunsg
Copy link
Member

I think this got buried in the notifications. @xavfernandez?

@xavfernandez
Copy link
Member

Sorry, I'm way behind on pip issues/PR/notifications...

Would adding a news/3972.feature be enough for this? Is there something more needed?

No the changelog must be added to 9.0 (where it was merged) changelog, so directly in NEWS.rst.

@pradyunsg pradyunsg mentioned this issue Jun 13, 2017
Merged
@pradyunsg pradyunsg mentioned this issue Jun 25, 2017
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation good first issue A good item for first time contributors to work on type: docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add news entry for upgrade-strategy pradyunsg/pip
3 participants
@gotgenes @xavfernandez @pradyunsg