-
Notifications
You must be signed in to change notification settings - Fork 3.1k
pip does not detect circular build dependency #4983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Relavant part: [build-system]
requires = ["pip-forkbomb-test"] I'd call this a release blocker. |
I don't think this should be a release blocker -- a package which wants to can already forkbomb you via setup.py, or by python code that you'll shortly import. |
I think I agree. Is there a realistic reason to assume (given that setuptools and wheel are available as universal wheels, so pip will never try to build them from source even on systems where they are not already present) that this could come about by accident, as opposed to via explicitly constructed malicious code? |
Note: gh-4987 resolves this issue. I don't have a position on whether this should be a release blocker (I was previously of a different opinion), but I don't see additional discussion on this issue as being helpful because it's already addressed in that PR. |
Oh, right. We still have code execution. XD I was imagining happier days. I imagine it would be possible that someone ends up with a potential build cycle and there I think it deserves an error message instead of a fork bomb. =) Not a blocker though. |
What I've run:
Curiously, the problem is most severe on solid-state-drives where there is minimal lag time, so the processes multiply quickly.
The text was updated successfully, but these errors were encountered: