Skip to content

"Display a message on Windows if pip is being modified" is triggered by get-pip.py #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pfmoore opened this issue Apr 14, 2018 · 1 comment · Fixed by #5233
Closed

"Display a message on Windows if pip is being modified" is triggered by get-pip.py #5219

pfmoore opened this issue Apr 14, 2018 · 1 comment · Fixed by #5233
Assignees
@pradyunsg
Labels
auto-locked Outdated issues that have been locked by automation
Milestone
10.0.1

Comments

@pfmoore
Copy link
Member

pfmoore commented Apr 14, 2018

The check in e41bad7 is too broad, as it detects running get-pip.py as an attempt to use pip to modify itself.
@pfmoore pfmoore added the !release blocker Hold a release until this is resolved label Apr 14, 2018
@pfmoore pfmoore added this to the 10.0.1 milestone Apr 14, 2018
@pradyunsg pradyunsg self-assigned this Apr 14, 2018
@pradyunsg pradyunsg mentioned this issue Apr 15, 2018
Merged
This was referenced Apr 16, 2018
Closed
Closed
@pradyunsg pradyunsg mentioned this issue Apr 17, 2018
Closed
@pradyunsg pradyunsg removed !release blocker Hold a release until this is resolved labels Feb 8, 2019
@lock
Copy link

lock bot commented May 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pradyunsg pradyunsg

Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
10.0.1
Development

Successfully merging a pull request may close this issue.

Make the Windows "self-modification" check more strict pradyunsg/pip
2 participants
@pfmoore @pradyunsg