Skip to content

pip install does not recognize missing extras in transitive dependecies #6698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Savlik opened this issue Jul 11, 2019 · 4 comments
Closed
Labels
auto-locked Outdated issues that have been locked by automation C: dependency resolution About choosing which dependencies to install type: bug A confirmed bug or unintended behavior

Comments

@Savlik
Copy link

Savlik commented Jul 11, 2019

Environment

  • pip version: 19.1.1
  • Python version: 3.7
  • OS: Linux

Description
When one of the shared transitive dependency have an extra that depends on something and it is later in the installation order, the extra dependency is not installed. See how to reproduce for example.

Expected behavior
All transitive dependencies including extras should be install not depending on the installation order.

How to Reproduce
Sorry, my working example uses internal libraries and I do not know how to reproduce the bug using only public ones.

Lets say, I have four libraries libA, libB, libC and libD. The dependecies goes:

  • libA -> libC
  • libB -> libC[extra] -> libD

Now when I run pip install libA liB, only libraries libA, libB and libC will be installed, as if the libC[extra] dependency was lost.

Both pip install libB libA and pip install libA && pip install libB produces correct result and all four libraries will be installed.

Maybe related issue #4086

@pradyunsg
Copy link
Member

This is basically #988.

@cjerdonek cjerdonek added the S: needs triage Issues/PRs that need to be triaged label Jul 17, 2019
@chrahunt chrahunt added C: dependency resolution About choosing which dependencies to install type: bug A confirmed bug or unintended behavior labels Jul 20, 2019
@ghost ghost removed the S: needs triage Issues/PRs that need to be triaged label Jul 20, 2019
@chrahunt
Copy link
Member

@pradyunsg is it worth addressing this independent of #988 or should it wait for/be incorporated into that?

@pradyunsg
Copy link
Member

We could but I'd personally really rather invest effort in a more comprehensive, complete fix.

@pradyunsg
Copy link
Member

Closing this since I don't think there's any reason to track this specific instance passing.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: dependency resolution About choosing which dependencies to install type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

No branches or pull requests

4 participants