Skip to content

New resolver: Extras on direct install does not work #8150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uranusjr opened this issue Apr 27, 2020 · 1 comment · Fixed by #8291
Closed

New resolver: Extras on direct install does not work #8150

uranusjr opened this issue Apr 27, 2020 · 1 comment · Fixed by #8291

Comments

@uranusjr
Copy link
Member

Context: #8146 (comment)

Some unorganised thoughts:

  • This does not work because if a direct install is not available from indexes, the resolver throws ResolutionImpossible on that package because it cannot find any mat
  • Maybe we can simply do ExplicitRequirement(self.base) here? Does this affect packages found on indexes?
  • Another solution here would be to include the direct install as a candidate in find_matches. This means we need to resolve all direct references eagerly, and yield them at the right location (likely just after the already installed candidate). I think this actually makes sense?
@ghost ghost added the S: needs triage Issues/PRs that need to be triaged label Apr 27, 2020
@ghost ghost removed the S: needs triage Issues/PRs that need to be triaged label Apr 27, 2020
@uranusjr
Copy link
Member Author

This is fixed in #8291.

@uranusjr uranusjr linked a pull request May 27, 2020 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant