Skip to content

PEP 517 backend: get_requires_for_build_wheel shouldn't include setuptools #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pfmoore opened this issue Oct 19, 2018 · 2 comments
Closed
Labels
bug Needs Implementation Issues that are ready to be implemented.

Comments

@pfmoore
Copy link
Member

pfmoore commented Oct 19, 2018

See pypa/pip#5743 (comment).

As the backend is part of setuptools, it doesn't need to request that setuptools is installed in get_requires_for_build_wheel. (And it certainly shouldn't be allowing any version - at a minimum it needs a version that supports the PEP 517 backend, but that's not important as it shouldn't be there in the first place 😉 )

@pganssle pganssle added the Needs Triage Issues that need to be evaluated for severity and status. label Oct 19, 2018
@benoit-pierre benoit-pierre added bug Needs Implementation Issues that are ready to be implemented. and removed Needs Triage Issues that need to be evaluated for severity and status. labels Oct 25, 2018
@pfmoore
Copy link
Member Author

pfmoore commented Nov 14, 2018

#1594 created for the fix. I also corrected the same mistake in get_requires_for_build_sdist.

@jaraco
Copy link
Member

jaraco commented Dec 11, 2018

Thanks for the patch, @pfmoore . This is releasing as 40.6.3.

@jaraco jaraco closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs Implementation Issues that are ready to be implemented.
Projects
None yet
Development

No branches or pull requests

4 participants