test_always_copy_option fails with pypy 2.5.0

[blueyed]

https://travis-ci.org/pypa/virtualenv/jobs/52800263

Running it locally:

% tox -e pypy -- -ktest_always_copy_option
GLOB sdist-make: venv/setup.py
pypy inst-nodeps: venv/.tox/dist/virtualenv-12.1.dev0.zip
pypy runtests: PYTHONHASHSEED='1328629911'
pypy runtests: commands[0] | py.test -ktest_always_copy_option
========================================================================== test session starts ==========================================================================
platform linux2 -- Python 2.7.8[pypy-2.5.0-final] -- py-1.4.26 -- pytest-2.6.4
collected 8 items 

tests/test_virtualenv.py F

=============================================================================== FAILURES ================================================================================
________________________________________________________________________ test_always_copy_option ________________________________________________________________________

    def test_always_copy_option():
        """Should be no symlinks in directory tree"""
        tmp_virtualenv = tempfile.mkdtemp()
        ve_path = os.path.join(tmp_virtualenv, 'venv')
        try:
            virtualenv.create_environment(ve_path, symlink=False)

            for root, dirs, files in os.walk(tmp_virtualenv):
                for f in files + dirs:
                    full_name = os.path.join(root, f)
>                   assert not os.path.islink(full_name), "%s should not be a" \
                        " symlink (to %s)" % (full_name, os.readlink(full_name))
E                       AssertionError: /tmp/tmpTFpOXs/venv/bin/libpypy-c.so should not be a symlink (to …/pyenv/pypy-2.5.0/bin/libpypy-c.so)
E                       assert not True
E                        +  where True = <function islink at 0x00007f6bcd17b1f0>('/tmp/tmpTFpOXs/venv/bin/libpypy-c.so')
E                        +    where <function islink at 0x00007f6bcd17b1f0> = <module 'posixpath' from 'venv/.tox/pypy/lib-python/2.7/posixpath.pyc'>.islink
E                        +      where <module 'posixpath' from 'venv/.tox/pypy/lib-python/2.7/posixpath.pyc'> = os.path

tests/test_virtualenv.py:136: AssertionError
=========================================================== 7 tests deselected by '-ktest_always_copy_option' ===========================================================
================================================================ 1 failed, 7 deselected in 4.86 seconds =================================================================
ERROR: InvocationError: 'venv/.tox/pypy/bin/py.test -ktest_always_copy_option'
pypy runtests: commands[1] | python virtualenv.py venv/.tox/pypy/tmp/test-venv-01
Using real prefix '…/pyenv/pypy-2.5.0'
Path not in prefix 'venv/.tox/pypy/include' '…/pyenv/pypy-2.5.0'
New pypy executable in venv/.tox/pypy/tmp/test-venv-01/bin/python
Also creating executable in venv/.tox/pypy/tmp/test-venv-01/bin/pypy
Installing setuptools, pip...done.
________________________________________________________________________________ summary ________________________________________________________________________________
ERROR:   pypy: commands failed
tox -e pypy -- -ktest_always_copy_option  12,56s user 1,09s system 100% cpu 13,641 total

[techtonik]

Can you try with pypy-2.4.0?

[blueyed]

It works with pypy-2.4.0-final.

via:

% pyenv shell pypy-2.4.0
% tox -e pypy

[techtonik]

Sent a note to pypy-dev. Hopefully, somebody will respond.
https://mail.python.org/pipermail/pypy-dev/2015-March/013220.html

[techtonik]

Got reply from Armin Rigo:

That's because pypy comes with a shared library since 2.5. I'll leave it to virtualenv people to decide if they need to fix the test or if there is a more serious problem for them. At least virtualenv seems to work in practice.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Just add a comment if you want to keep it open. Thank you for your contributions.