fix at least one test

Author: ewdurbin

tests/common/db/packaging.py

@@ -101,6 +101,7 @@ class Meta:
 
     name = factory.fuzzy.FuzzyText(length=12)
     version = factory.Sequence(lambda n: str(n) + ".0")
+    release = project = factory.SubFactory(ReleaseFactory)
     kind = factory.fuzzy.FuzzyChoice(int(kind) for kind in DependencyKind)
     specifier = factory.fuzzy.FuzzyText(length=12)
 

warehouse/migrations/versions/ee5b8f66a223_migrate_projects_and_releases_to_.py

@@ -114,11 +114,12 @@ def upgrade():
     )
 
     op.alter_column("releases", "project_id", nullable=False)
-    op.alter_column("roles", "package_name", nullable=False)
     op.alter_column("release_files", "release_id", nullable=False)
     op.alter_column("release_dependencies", "release_id", nullable=False)
     op.alter_column("release_classifiers", "release_id", nullable=False)
 
+    op.drop_column("roles", "package_name")
+
     op.drop_constraint(
         "release_classifiers_name_fkey", "release_classifiers", type_="foreignkey"
     )

warehouse/packaging/models.py

@@ -53,10 +53,7 @@
 class Role(db.Model):
 
     __tablename__ = "roles"
-    __table_args__ = (
-        Index("roles_pack_name_idx", "package_name"),
-        Index("roles_user_name_idx", "user_name"),
-    )
+    __table_args__ = (Index("roles_user_name_idx", "user_name"),)
 
     __repr__ = make_repr("role_name", "user_name", "package_name")
 
@@ -69,11 +66,14 @@ class Role(db.Model):
         ForeignKey("packages.id", onupdate="CASCADE", ondelete="CASCADE"),
         nullable=False,
     )
-    package_name = Column(Text)
 
     user = orm.relationship(User, lazy=False)
     project = orm.relationship("Project", lazy=False)
 
+    @property
+    def package_name(self):
+        return project.name
+
     def __gt__(self, other):
         """
         Temporary hack to allow us to only display the 'highest' role when