-
Notifications
You must be signed in to change notification settings - Fork 1k
2FA User Interfaces (authentication workflow) #5587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@woodruffw if this proposal looks good to you, I will update #5567 to include the appropriate changes. |
@nlhkabu This looks great to me! I really like the design.
👍 Feel free to update #5567 whenever you're ready! |
JFYI: I'm going to push some more unit tests today, so you'll probably need to rebase before adding the templates. |
@woodruffw mentioned today in IRC:
@nlhkabu is there anything you need for the latter? |
@brainwane - nothing needed on my side. Just need the go-ahead from @woodruffw. @woodruffw are you ok for me to pull down #5795 and update templates? |
@nlhkabu Yep! |
@nlhkabu how's this going? |
I believe the one remaining task here will be to support the API keys in #994 which will be another auth method. |
I presume you'll be adding API key user interfaces to commits in #6084 ? |
That's right @brainwane - @woodruffw pinged me yesterday on this, and I'm starting work on that today :) |
Is there anything left to be done in this issue, @nlhkabu, or can we close it? |
Yes, let's close. Recovery codes are missing, but this is documented in #5800 |
Proposed UI for 2FA login workflow (swap purple for PyPI blue... and voila!):
Notes:
@woodruffw - I decided that it would be better to separate the recovery codes from the key authentication (e.g. not use the same form, as we had discussed), because they are not equal in effectiveness. A recovery code can only be used once, and is bypassing the 2FA process - for this reason, we want to discourage their use to only 'emergency' situations. My concern with using the same form as the key input, is that users will believe these methods are equal in value.
Screenshot Required: This issue will require an update to the visual design of the site. To help our team give you faster feedback, include a screenshot in your Pull Request.
The text was updated successfully, but these errors were encountered: