Continuing improve download files page layout #18982
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #18741
Additions:
Update url based on the selected filters.
Limit the filters based on what the user has already selected.
The File column does not show the full file name.
I changed this to save space, and because the useful information is now available in the other columns of the table.
The filters now use the display tags for the labels, and the actual tags for the values.
The bdist table uses the display tags.
The dropdown filters are now exact matches.
For example: the files that match by 'includes' using the search:
And the files that match by exact match using the ABI dropdown:
