-
Notifications
You must be signed in to change notification settings - Fork 8
Dont use editable packages ? #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Or maybe it will encourage good habits (C++ flow with cmake in low level, highly dynamic flow without cmake, in venv high level, or other environment, connected with pyros), while not breaking the fact that python code runs in ROS workspaces. |
Attempt : #90 |
Note this "regression" will not affect the main use of catkin_pip : take existing python packages and catkinize them without changing anything. |
Also it might be tricky but we would need to ensure python sources and targets are linked properly, to trigger rebuild when needed... |
#90 kind of break the user expectation regarding the workflow (has to build after editing, and before testing...) We are able to avoid annoying pip bugs and simplify hacks between ROS and python, but the cost (loosing python dynamic advantage) might be too great...
|
We will stick with editable packages for now. We should just focus on fixing pip bugs, but editable packages have the correct semantic for ROS devel space packages. |
editable packages create problems (compatibility with --prefix, dynamic discovery of their paths, etc.).
Although this feature might be interesting coming from python, it kind of break a few things in subtle ways when using catkin.
How about not using editable packages, and doing a REAL (pip) install into the devel workspace ?
This will solve a few tricky problems, and the drawbacks are that you need to build again before you can use the edited version... Maybe not such a problem if people are used to work with C++ and are using CMake anyway...
The text was updated successfully, but these errors were encountered: