Merge pull request #511 from pytest-dev/no-fail-collectonly

`--cov-fail-under` should not cause `pytest --collect-only` to fail

Author: ionelmc

AUTHORS.rst

@@ -50,3 +50,4 @@ Authors
 * Brian Rutledge - https://github.com/bhrutledge
 * Danilo Šegan - https://github.com/dsegan
 * Michał Bielawski - https://github.com/D3X
+* Zac Hatfield-Dodds - https://github.com/Zac-HD

CHANGELOG.rst

@@ -2,6 +2,14 @@ Changelog
 =========
 
 
+3.1.0 (future)
+-------------------
+
+* `--cov-fail-under` no longer causes `pytest --collect-only` to fail
+  Contributed by Zac Hatfield-Dodds in
+  `#511 <https://github.com/pytest-dev/pytest-cov/pull/511>`_.
+
+
 3.0.0 (2021-10-04)
 -------------------
 

src/pytest_cov/plugin.py

@@ -308,7 +308,7 @@ def pytest_runtestloop(self, session):
                 warnings.warn(CovReportWarning(message))
                 self.cov_total = 0
             assert self.cov_total is not None, 'Test coverage should never be `None`'
-            if self._failed_cov_total():
+            if self._failed_cov_total() and not self.options.collectonly:
                 # make sure we get the EXIT_TESTSFAILED exit code
                 compat_session.testsfailed += 1
 

tests/test_pytest_cov.py

@@ -389,6 +389,19 @@ def test_cov_min_100(testdir):
     ])
 
 
+def test_cov_min_100_passes_if_collectonly(testdir):
+    script = testdir.makepyfile(SCRIPT)
+
+    result = testdir.runpytest('-v',
+                               '--cov=%s' % script.dirpath(),
+                               '--cov-report=term-missing',
+                               '--cov-fail-under=100',
+                               '--collect-only',
+                               script)
+
+    assert result.ret == 0
+
+
 def test_cov_min_50(testdir):
     script = testdir.makepyfile(SCRIPT)