Skip to content

Commit 3af781d

Browse files
Fix image missing when using Base64 content
1 parent 0f6c16a commit 3af781d

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

pytest_html/plugin.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,12 @@ def _make_media_html_div(
291291
href = src = self.create_asset(
292292
content, extra_index, test_index, extra.get("extension"), "wb"
293293
)
294-
html_div = html.a(class_=base_extra_class, target="_blank", href=href)
294+
html_div = html.a(
295+
raw(base_extra_string.format(src)),
296+
class_=base_extra_class,
297+
target="_blank",
298+
href=href,
299+
)
295300
return html_div
296301

297302
def _append_image(self, extra, extra_index, test_index):

testing/test_pytest_html.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,9 @@ def pytest_runtest_makereport(item, call):
494494
assert result.ret == 0
495495
src = f"assets/test_extra_image_separated.py__test_pass_0_0.{file_extension}"
496496
link = f'<a class="image" href="{src}" target="_blank">'
497+
img = f'<img src="{src}"/>'
497498
assert link in html
499+
assert img in html
498500
assert os.path.exists(src)
499501

500502
@pytest.mark.parametrize(
@@ -528,8 +530,10 @@ def test_fail():
528530
asset_name = "test_extra_image_separated_rerun.py__test_fail"
529531
src = f"assets/{asset_name}_0_{i}.{file_extension}"
530532
link = f'<a class="image" href="{src}" target="_blank">'
533+
img = f'<img src="{src}"/>'
531534
assert result.ret
532535
assert link in html
536+
assert img in html
533537
assert os.path.exists(src)
534538

535539
@pytest.mark.parametrize("src_type", ["https://", "file://", "image.png"])

0 commit comments

Comments
 (0)