Skip to content

Commit 65e0c9a

Browse files
committed
Feature: Make entire row collapsible
1 parent f2cf3b2 commit 65e0c9a

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

src/layout/css/style.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,13 @@ div.media {
193193
cursor: pointer;
194194
}
195195

196-
.col-result {
196+
.collapsible td:not(.col-links) {
197197
cursor: pointer;
198198
&:hover::after {
199199
@include rowToggle;
200200
}
201201
}
202+
202203
.col-result.collapser {
203204
&:hover::after {
204205
content: ' (hide details)';

src/pytest_html/resources/index.jinja2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
</template>
3030
<template id="template_results-table__tbody">
3131
<tbody class="results-table-row">
32-
<tr>
32+
<tr class="collapsible">
3333
<td class="col-result"></td>
3434
<td class="col-name"></td>
3535
<td class="col-duration"></td>

src/pytest_html/resources/style.css

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/pytest_html/scripts/dom.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ const dom = {
8585
const resultBody = templateResult.content.cloneNode(true)
8686
resultBody.querySelector('tbody').classList.add(resultLower)
8787
resultBody.querySelector('tbody').id = testId
88+
resultBody.querySelector('.collapsible').dataset.id = id
8889
resultBody.querySelector('.col-result').innerText = result
8990
resultBody.querySelector('.col-result').classList.add(`${collapsed ? 'expander' : 'collapser'}`)
90-
resultBody.querySelector('.col-result').dataset.id = id
9191
resultBody.querySelector('.col-name').innerText = testId
9292

9393
const formattedDuration = duration < 1 ? formatDuration(duration).ms : formatDuration(duration).formatted

src/pytest_html/scripts/main.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ const renderContent = (tests) => {
6565
redraw()
6666
})
6767
})
68-
findAll('.col-result').forEach((elem) => {
68+
findAll('.collapsible td:not(.col-links').forEach((elem) => {
6969
elem.addEventListener('click', ({ target }) => {
70-
manager.toggleCollapsedItem(target.dataset.id)
70+
manager.toggleCollapsedItem(target.parentElement.dataset.id)
7171
redraw()
7272
})
7373
})

0 commit comments

Comments
 (0)