pytest.mark in class marks methods defined in the class body only

Author: nicoddemus

CHANGELOG

@@ -26,6 +26,11 @@
   all directories that do not contain tests.
   Thanks to Adrian for idea (#694) and Bruno Oliveira for the PR.
 
+- fix issue725: pytest.mark in class decorators will mark methods defined
+  in the class body only, instead of propagating marks to the superclass'
+  test methods.
+  Thanks to foobarbazquux for the report and Bruno Oliveira for the PR.
+
 - fix issue713: JUnit XML reports for doctest failures.
   Thanks Punyashloka Biswal.
 

_pytest/python.py

@@ -474,16 +474,23 @@ def __init__(self, argnames, names_closure, name2fixturedefs):
 def transfer_markers(funcobj, cls, mod):
     # XXX this should rather be code in the mark plugin or the mark
     # plugin should merge with the python plugin.
-    for holder in (cls, mod):
+    def transfer(holder):
         try:
             pytestmark = holder.pytestmark
         except AttributeError:
-            continue
-        if isinstance(pytestmark, list):
-            for mark in pytestmark:
-                mark(funcobj)
+            pass
         else:
-            pytestmark(funcobj)
+            if isinstance(pytestmark, list):
+                for mark in pytestmark:
+                    mark(funcobj)
+            else:
+                pytestmark(funcobj)
+
+    # transfer markers from class decorators only if the method is defined
+    # in the class itself
+    if cls is not None and funcobj.__name__ in cls.__dict__:
+        transfer(cls)
+    transfer(mod)
 
 class Module(pytest.File, PyCollector):
     """ Collector for test classes and functions. """

testing/test_mark.py

@@ -477,6 +477,39 @@ def test_some(request):
         reprec = testdir.inline_run("-m", "mark1")
         reprec.assertoutcome(passed=1)
 
+    def test_class_makker_applies_to_its_own_methods_only(self, testdir):
+        """Check that markers applied using class decorators apply markers
+        only to methods defined in the class itself but not to methods
+        in super classes (#725).
+        """
+        testdir.makepyfile("""
+            import pytest
+
+            class Base:
+                def test_base(self):
+                    pass
+
+            @pytest.mark.a
+            class Test1(Base):
+                def test_foo(self):
+                    pass
+
+            @pytest.mark.b
+            class Test2(Base):
+                def test_bar(self):
+                    pass
+        """)
+        result = testdir.runpytest('--collect-only', '-m', 'a')
+        result.stdout.fnmatch_lines([
+            '*test_foo*',
+            '*3 deselected*'
+        ])
+        result = testdir.runpytest('--collect-only', '-m', 'b')
+        result.stdout.fnmatch_lines([
+            '*test_bar*',
+            '*3 deselected*'
+        ])
+
 class TestKeywordSelection:
     def test_select_simple(self, testdir):
         file_test = testdir.makepyfile("""