Skip to content

Commit ff80464

Browse files
committed
last-failed: display skipped-files msg always
1 parent 480dd9e commit ff80464

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

src/_pytest/cacheprovider.py

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -233,19 +233,15 @@ def pytest_collection_modifyitems(self, session, config, items):
233233
items[:] = previously_failed + previously_passed
234234

235235
noun = "failure" if self._previously_failed_count == 1 else "failures"
236-
if self._skipped_files > 0:
237-
files_noun = "file" if self._skipped_files == 1 else "files"
238-
skipped_files_msg = " (skipped {files} {files_noun})".format(
239-
files=self._skipped_files, files_noun=files_noun
240-
)
241-
else:
242-
skipped_files_msg = ""
243236
suffix = " first" if self.config.getoption("failedfirst") else ""
244-
self._report_status = "rerun previous {count} {noun}{suffix}{skipped_files}".format(
245-
count=self._previously_failed_count,
246-
suffix=suffix,
247-
noun=noun,
248-
skipped_files=skipped_files_msg,
237+
self._report_status = "rerun previous {count} {noun}{suffix}".format(
238+
count=self._previously_failed_count, suffix=suffix, noun=noun
239+
)
240+
241+
if self._skipped_files > 0:
242+
files_noun = "file" if self._skipped_files == 1 else "files"
243+
self._report_status += " (skipped {files} {files_noun})".format(
244+
files=self._skipped_files, files_noun=files_noun
249245
)
250246
else:
251247
self._report_status = "no previously failed tests, "

testing/test_cacheprovider.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -869,7 +869,7 @@ def test_lastfailed_with_known_failures_not_being_selected(self, testdir):
869869
result.stdout.fnmatch_lines(
870870
[
871871
"collected 1 item",
872-
"run-last-failure: 1 known failures not in selected tests",
872+
"run-last-failure: 1 known failures not in selected tests (skipped 1 file)",
873873
"* 1 failed in *",
874874
]
875875
)

0 commit comments

Comments
 (0)