Skip to content

FR: Full Object Support in Cache #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerodg opened this issue Feb 4, 2019 · 2 comments
Closed

FR: Full Object Support in Cache #4717

jerodg opened this issue Feb 4, 2019 · 2 comments
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature

Comments

@jerodg
Copy link

jerodg commented Feb 4, 2019

It would be awesome if the cache had better support for objects. i.e. dicts, classes, dataclasses, etc.

@RonnyPfannschmidt
Copy link
Member

limiting it to json prevents a major set of headaches that complete serialization imposes (cycles, attack vectors

so from my pov there needs to be a good proposal and a sane sheme that we can sanely move to

without that im -1 on it

@RonnyPfannschmidt RonnyPfannschmidt added type: enhancement new feature or API change, should be merged into features branch type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: feature-branch new feature or API change, should be merged into features branch labels Feb 4, 2019
@Zac-HD
Copy link
Member

Zac-HD commented Feb 25, 2019

See #2899 - this is unlikely to be supported due to the security and maintenance headaches it would impose.

You can get around that by storing pickled objects as strings if you really want to; the headaches may still exist but then they're your problem not ours.

@Zac-HD Zac-HD closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature
Projects
None yet
Development

No branches or pull requests

3 participants