Skip to content

Comment shows incorrect choices. #6617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BhanuPrakashN opened this issue Jan 29, 2020 · 1 comment · Fixed by #6677
Closed

Comment shows incorrect choices. #6617

BhanuPrakashN opened this issue Jan 29, 2020 · 1 comment · Fixed by #6677
Labels
good first issue easy issue that is friendly to new contributor plugin: junitxml related to the junitxml builtin plugin type: enhancement new feature or API change, should be merged into features branch

Comments

@BhanuPrakashN
Copy link

pytest/src/_pytest/junitxml.py

Line 413 in 8e1d59a

) # choices=['no', 'stdout', 'stderr'])

@Zac-HD Zac-HD added plugin: junitxml related to the junitxml builtin plugin good first issue easy issue that is friendly to new contributor type: enhancement new feature or API change, should be merged into features branch labels Jan 30, 2020
@Zac-HD
Copy link
Member

Zac-HD commented Jan 30, 2020

Fixing the comment would be a good first contribution.

If you want to go further, you could un-comment the choices argument so the ini values are actually validated! It looks like they were commented out when the feature was first added, but IMO we should have this validation enabled.

@rana-ahmed rana-ahmed mentioned this issue Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue easy issue that is friendly to new contributor plugin: junitxml related to the junitxml builtin plugin type: enhancement new feature or API change, should be merged into features branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove incorrect choices comment. rana-ahmed/pytest
2 participants
@Zac-HD @BhanuPrakashN