Skip to content

Add support for native TOML checking of instances #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mondeja opened this issue May 30, 2022 · 4 comments
Closed

Add support for native TOML checking of instances #95

mondeja opened this issue May 30, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@mondeja
Copy link
Contributor

mondeja commented May 30, 2022

Hi, I was reading the thread python-jsonschema/jsonschema#582 and I'm very interested in native TOML instance reading support. Do you still plan to add this, only would be added if other users ask it...? As I'm seeing in the source code, seems to be relatively easy to implement, so let me know if you want some help with it.

Thanks for the great work, cheers!

@sirosen
Copy link
Member

sirosen commented May 30, 2022

Yes, I was only planning to add it if someone came along and requested it. It wasn't clear to me in the original thread whether or not anyone wanted TOML specifically, or if it was just being included in the list of other file formats which can be loaded into nested dicts.

Thanks for submitting the issue!

I have some time today to look into this. Although I'm always open to PRs, it might be easier to just wait a little bit.

@sirosen
Copy link
Member

sirosen commented May 30, 2022

There's now support for this in main -- as expected, it was quite simple.

I would appreciate some additional test data to work against. For the purposes of getting it working, I used this extremely simple file. If there's a more sophisticated case I could add to the acceptance tests, that would be great.


I don't plan to release at least until I sort out the type-checking situation with updates to the jsonschema typeshed stubs. Hopefully that's easy for me to knock out shortly.

@sirosen sirosen added the enhancement New feature or request label May 30, 2022
@mondeja
Copy link
Contributor Author

mondeja commented May 31, 2022

Thank you! 👍🏼

I would appreciate some additional test data to work against. For the purposes of getting it working, I used this extremely simple file. If there's a more sophisticated case I could add to the acceptance tests, that would be great.

Opened #98

@sirosen
Copy link
Member

sirosen commented Jun 6, 2022

I've just released v0.16.0 with support for TOML files if tomli is installed.

Please definitely let me know if you see any issues using it!

@sirosen sirosen closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants