-
-
Notifications
You must be signed in to change notification settings - Fork 591
Fragment handling for unknown schemes #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We could provide our own versions of |
Possibly also do this for |
Seems like the patch from http://bugs.python.org/issue9374 is probably what we want? Looks like it was backed out from being back ported to 2.7. No? |
Yeah, that patch would fix our issue. What are you thinking, monkeypatch urlparse? |
(Well it would fix fragment issue. Combining relative uris with the base uri also works differently with unknown schemes, but I'm thinking maybe user is responsible for adding their scheme to |
No need to monkey patch, just copy and paste to include it would work along with using the one we include rather than |
Oh hmm, why was I being silly? Yes, this makes sense. |
We use
urldefrag
andurlparse
to deal with splitting fragments, and on python < 3.3 this doesn't work for URIs with unknown schemes, e.g.foo://bar#something
The text was updated successfully, but these errors were encountered: