Type all remaining tests (#2820)

* add types to all remaining tests
* make trio.ssl.SSLStream and SSLListener generic
* export trio.lowlevel.RunVarToken

---------

Co-authored-by: CoolCat467 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 3 people

.coveragerc

@@ -20,7 +20,7 @@ skip_covered = True
 exclude_lines =
   pragma: no cover
   abc.abstractmethod
-  if TYPE_CHECKING:
+  if TYPE_CHECKING.*:
   if _t.TYPE_CHECKING:
   if t.TYPE_CHECKING:
   @overload

.pre-commit-config.yaml

@@ -28,6 +28,7 @@ repos:
       - id: ruff
         types: [file]
         types_or: [python, pyi, toml]
+        args: ["--show-fixes"]
   - repo: https://github.com/codespell-project/codespell
     rev: v2.2.6
     hooks:

docs/source/conf.py

@@ -71,6 +71,8 @@
     # "types.FrameType" is more helpful than just "frame"
     "FrameType": "types.FrameType",
     "Context": "OpenSSL.SSL.Context",
+    # SSLListener.accept's return type is seen as trio._ssl.SSLStream
+    "SSLStream": "trio.SSLStream",
 }
 
 

pyproject.toml

@@ -77,56 +77,13 @@ warn_return_any = true
 # Avoid subtle backsliding
 disallow_any_decorated = true
 disallow_any_generics = true
-disallow_any_unimported = false  # Enable once Outcome has stubs.
+disallow_any_unimported = true
 disallow_incomplete_defs = true
 disallow_subclassing_any = true
+disallow_untyped_calls = true
 disallow_untyped_decorators = true
 disallow_untyped_defs = true
-
-# Enable once other problems are dealt with
 check_untyped_defs = true
-disallow_untyped_calls = false
-
-# files not yet fully typed
-[[tool.mypy.overrides]]
-module = [
-# tests
-"trio/testing/_fake_net",
-"trio/_core/_tests/test_guest_mode",
-"trio/_core/_tests/test_instrumentation",
-"trio/_core/_tests/test_ki",
-"trio/_core/_tests/test_local",
-"trio/_core/_tests/test_mock_clock",
-"trio/_core/_tests/test_multierror",
-"trio/_core/_tests/test_multierror_scripts/ipython_custom_exc",
-"trio/_core/_tests/test_multierror_scripts/simple_excepthook",
-"trio/_core/_tests/test_parking_lot",
-"trio/_core/_tests/test_thread_cache",
-"trio/_core/_tests/test_unbounded_queue",
-"trio/_tests/test_exports",
-"trio/_tests/test_file_io",
-"trio/_tests/test_highlevel_generic",
-"trio/_tests/test_highlevel_open_unix_stream",
-"trio/_tests/test_highlevel_serve_listeners",
-"trio/_tests/test_highlevel_ssl_helpers",
-"trio/_tests/test_scheduler_determinism",
-"trio/_tests/test_ssl",
-"trio/_tests/test_subprocess",
-"trio/_tests/test_sync",
-"trio/_tests/test_testing",
-"trio/_tests/test_threads",
-"trio/_tests/test_timeouts",
-"trio/_tests/test_tracing",
-"trio/_tests/test_util",
-"trio/_tests/test_wait_for_object",
-"trio/_tests/tools/test_gen_exports",
-]
-check_untyped_defs = false
-disallow_any_decorated = false
-disallow_any_generics = false
-disallow_any_unimported = false
-disallow_incomplete_defs = false
-disallow_untyped_defs = false
 
 [tool.pytest.ini_options]
 addopts = ["--strict-markers", "--strict-config"]

trio/_core/__init__.py

@@ -18,7 +18,7 @@
     WouldBlock,
 )
 from ._ki import currently_ki_protected, disable_ki_protection, enable_ki_protection
-from ._local import RunVar
+from ._local import RunVar, RunVarToken
 from ._mock_clock import MockClock
 from ._parking_lot import ParkingLot, ParkingLotStatistics
 

trio/_core/_local.py

@@ -17,7 +17,7 @@ class _NoValue:
 
 
 @final
-@attr.s(eq=False, hash=False, slots=False)
+@attr.s(eq=False, hash=False, slots=True)
 class RunVarToken(Generic[T], metaclass=NoPublicConstructor):
     _var: RunVar[T] = attr.ib()
     previous_value: T | type[_NoValue] = attr.ib(default=_NoValue)

trio/_core/_multierror.py

@@ -424,9 +424,8 @@ def copy_tb(base_tb: TracebackType, tb_next: TracebackType | None) -> TracebackT
 else:
     # http://doc.pypy.org/en/latest/objspace-proxies.html
     def copy_tb(base_tb: TracebackType, tb_next: TracebackType | None) -> TracebackType:
-        # Mypy refuses to believe that ProxyOperation can be imported properly
-        # TODO: will need no-any-unimported if/when that's toggled on
-        def controller(operation: tputil.ProxyOperation) -> Any | None:
+        # tputil.ProxyOperation is PyPy-only, but we run mypy on CPython
+        def controller(operation: tputil.ProxyOperation) -> Any | None:  # type: ignore[no-any-unimported]
             # Rationale for pragma: I looked fairly carefully and tried a few
             # things, and AFAICT it's not actually possible to get any
             # 'opname' that isn't __getattr__ or __getattribute__. So there's