-
-
Notifications
You must be signed in to change notification settings - Fork 60
Add type-refactor
label
#563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Another example that recently appeared: |
Some other examples:
There are probably more but this would at least separate what's a real feature from what's a refactorization (sometimes internal, sometimes not). |
After python/cpython#131238, and other issues that are meant to target refactorization-only (and not really feature), I become more and more convinced that we need such label. @ezio-melotti Are you willing to create this new label? (I don't know which color to use though so I leave it to you, but maybe some purple? (in between the issue red and the blue feature)) |
Perhaps |
|
What other types of changes would |
It could be something affecting the Nevertheless, I would be happy if we had a way to distinguish features from refactoring because most of the time, refactoring doesn't require a what's new and refactoring can be follow-ups of bug fixes, in which case those are not backported. |
Although we discourage refactoring in general, there is sometimes a valid need for refactoring. Recent examples would be Irit's refactoring of the compiler and Mark Shannon's proposal for more readable type defs. We've historically also done (and are still doing) several test refactorings:
test_dis
into a directory by separating generated content cpython#123361Currently, we use
type-feature
for these efforts, but it may be beneficial to be able to differentiate between (real1) features and refactorings.Footnotes
user-facing ↩
The text was updated successfully, but these errors were encountered: