Skip to content

Add type-refactor label #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erlend-aasland opened this issue Dec 6, 2024 · 7 comments
Open

Add type-refactor label #563

erlend-aasland opened this issue Dec 6, 2024 · 7 comments
Assignees
Labels
labels Issues related to GitHub label changes

Comments

@erlend-aasland
Copy link

Although we discourage refactoring in general, there is sometimes a valid need for refactoring. Recent examples would be Irit's refactoring of the compiler and Mark Shannon's proposal for more readable type defs. We've historically also done (and are still doing) several test refactorings:

Currently, we use type-feature for these efforts, but it may be beneficial to be able to differentiate between (real1) features and refactorings.

Footnotes

  1. user-facing

@erlend-aasland erlend-aasland added the labels Issues related to GitHub label changes label Dec 6, 2024
@erlend-aasland
Copy link
Author

Another example that recently appeared:

@picnixz
Copy link
Member

picnixz commented Feb 10, 2025

Some other examples:

There are probably more but this would at least separate what's a real feature from what's a refactorization (sometimes internal, sometimes not).

@picnixz
Copy link
Member

picnixz commented Mar 14, 2025

After python/cpython#131238, and other issues that are meant to target refactorization-only (and not really feature), I become more and more convinced that we need such label.

@ezio-melotti Are you willing to create this new label? (I don't know which color to use though so I leave it to you, but maybe some purple? (in between the issue red and the blue feature))

@AA-Turner
Copy link
Member

Perhaps type-internal? If the goal is "to differentiate between [user-facing] features and refactorings".

@picnixz
Copy link
Member

picnixz commented Mar 14, 2025

type-internal would also be interesting! because sometimes it's more of an internal thing (and we coud use it for the different Tools that we don't ship it yet)

@erlend-aasland
Copy link
Author

What other types of changes would type-internal encompass, apart from refactorings?

@picnixz
Copy link
Member

picnixz commented Mar 23, 2025

It could be something affecting the Tools for instance. I've opened the topic-tools label and saw that there were arguments in favor and against in a previous discussion. However, what we can probably safely say, is that whatever is in Tools is roughly something internal. Now, I don't know if mixing type-bug and type-internal would make sense to others or type-internal and type-feature in that case.

Nevertheless, I would be happy if we had a way to distinguish features from refactoring because most of the time, refactoring doesn't require a what's new and refactoring can be follow-ups of bug fixes, in which case those are not backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labels Issues related to GitHub label changes
Projects
None yet
Development

No branches or pull requests

4 participants