gh-110241: Add missing error check to record_eval in _testinternalcapi (#110242)

sobolevn · web-flow · commit 4596c76d1a76 · 2023-10-02T21:19:32.000Z
diff --git a/Modules/_testinternalcapi.c b/Modules/_testinternalcapi.c
@@ -675,7 +675,11 @@ record_eval(PyThreadState *tstate, struct _PyInterpreterFrame *f, int exc)
         assert(module != NULL);
         module_state *state = get_module_state(module);
         Py_DECREF(module);
-        PyList_Append(state->record_list, ((PyFunctionObject *)f->f_funcobj)->func_name);
+        int res = PyList_Append(state->record_list,
+                                ((PyFunctionObject *)f->f_funcobj)->func_name);
+        if (res < 0) {
+            return NULL;
+        }
     }
     return _PyEval_EvalFrameDefault(tstate, f, exc);
 }

Original file line number	Diff line number	Diff line change
`@@ -675,7 +675,11 @@ record_eval(PyThreadState tstate, struct _PyInterpreterFrame f, int exc)`
`675`	`675`	`assert(module != NULL);`
`676`	`676`	`module_state *state = get_module_state(module);`
`677`	`677`	`Py_DECREF(module);`
`678`		`- PyList_Append(state->record_list, ((PyFunctionObject *)f->f_funcobj)->func_name);`
	`678`	`+ int res = PyList_Append(state->record_list,`
	`679`	`+ ((PyFunctionObject *)f->f_funcobj)->func_name);`
	`680`	`+ if (res < 0) {`
	`681`	`+ return NULL;`
	`682`	`+ }`
`679`	`683`	`}`
`680`	`684`	`return _PyEval_EvalFrameDefault(tstate, f, exc);`
`681`	`685`	`}`