Skip to content

Commit cef28f1

Browse files
committed
gh-105922: PyImport_AddModule() uses Py_DECREF()
Rewrite PyImport_AddModule() to simply call Py_DECREF(), rather than creating a weak reference, to get a borrowed reference to the module.
1 parent c38da1e commit cef28f1

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

Python/import.c

+1-10
Original file line numberDiff line numberDiff line change
@@ -372,16 +372,7 @@ PyImport_AddModuleObject(PyObject *name)
372372
if (!mod) {
373373
return NULL;
374374
}
375-
376-
// gh-86160: PyImport_AddModuleObject() returns a borrowed reference
377-
PyObject *ref = PyWeakref_NewRef(mod, NULL);
378-
Py_DECREF(mod);
379-
if (ref == NULL) {
380-
return NULL;
381-
}
382-
383-
mod = PyWeakref_GetObject(ref);
384-
Py_DECREF(ref);
375+
Py_DECREF(mod); // sys.modules holds a strong reference
385376
return mod; /* borrowed reference */
386377
}
387378

0 commit comments

Comments
 (0)