Skip to content

Commit d82f2ca

Browse files
author
Erlend Egeberg Aasland
authored
bpo-45847: Port _socket to PY_STDLIB_MOD (GH-29713)
1 parent 758a23d commit d82f2ca

File tree

4 files changed

+19
-4
lines changed

4 files changed

+19
-4
lines changed

Modules/Setup.stdlib.in

+1
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
@MODULE__POSIXSUBPROCESS_TRUE@_posixsubprocess _posixsubprocess.c
110110
@MODULE_RESOURCE_TRUE@resource resource.c
111111
@MODULE_SELECT_TRUE@select selectmodule.c
112+
@MODULE__SOCKET_TRUE@_socket socketmodule.c
112113
# AIX has shadow passwords, but does not provide getspent API
113114
@MODULE_SPWD_TRUE@spwd spwdmodule.c
114115
@MODULE_SYSLOG_TRUE@syslog syslogmodule.c

configure

+15
Original file line numberDiff line numberDiff line change
@@ -724,6 +724,8 @@ MODULE__TYPING_FALSE
724724
MODULE__TYPING_TRUE
725725
MODULE__STRUCT_FALSE
726726
MODULE__STRUCT_TRUE
727+
MODULE__SOCKET_FALSE
728+
MODULE__SOCKET_TRUE
727729
MODULE_SELECT_FALSE
728730
MODULE_SELECT_TRUE
729731
MODULE__RANDOM_FALSE
@@ -20577,6 +20579,15 @@ else
2057720579
fi
2057820580
as_fn_append MODULE_BLOCK "MODULE_SELECT=yes$as_nl"
2057920581

20582+
if true; then
20583+
MODULE__SOCKET_TRUE=
20584+
MODULE__SOCKET_FALSE='#'
20585+
else
20586+
MODULE__SOCKET_TRUE='#'
20587+
MODULE__SOCKET_FALSE=
20588+
fi
20589+
as_fn_append MODULE_BLOCK "MODULE__SOCKET=yes$as_nl"
20590+
2058020591
if true; then
2058120592
MODULE__STRUCT_TRUE=
2058220593
MODULE__STRUCT_FALSE='#'
@@ -22099,6 +22110,10 @@ if test -z "${MODULE_SELECT_TRUE}" && test -z "${MODULE_SELECT_FALSE}"; then
2209922110
as_fn_error $? "conditional \"MODULE_SELECT\" was never defined.
2210022111
Usually this means the macro was only invoked conditionally." "$LINENO" 5
2210122112
fi
22113+
if test -z "${MODULE__SOCKET_TRUE}" && test -z "${MODULE__SOCKET_FALSE}"; then
22114+
as_fn_error $? "conditional \"MODULE__SOCKET\" was never defined.
22115+
Usually this means the macro was only invoked conditionally." "$LINENO" 5
22116+
fi
2210222117
if test -z "${MODULE__STRUCT_TRUE}" && test -z "${MODULE__STRUCT_FALSE}"; then
2210322118
as_fn_error $? "conditional \"MODULE__STRUCT\" was never defined.
2210422119
Usually this means the macro was only invoked conditionally." "$LINENO" 5

configure.ac

+1
Original file line numberDiff line numberDiff line change
@@ -6137,6 +6137,7 @@ PY_STDLIB_MOD_SIMPLE([_posixsubprocess])
61376137
PY_STDLIB_MOD_SIMPLE([_queue])
61386138
PY_STDLIB_MOD_SIMPLE([_random])
61396139
PY_STDLIB_MOD_SIMPLE([select])
6140+
PY_STDLIB_MOD_SIMPLE([_socket])
61406141
PY_STDLIB_MOD_SIMPLE([_struct])
61416142
PY_STDLIB_MOD_SIMPLE([_typing])
61426143
PY_STDLIB_MOD_SIMPLE([_xxsubinterpreters])

setup.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -1034,6 +1034,8 @@ def detect_simple_extensions(self):
10341034
self.addext(Extension('fcntl', ['fcntlmodule.c']))
10351035
# grp(3)
10361036
self.addext(Extension('grp', ['grpmodule.c']))
1037+
1038+
self.addext(Extension('_socket', ['socketmodule.c']))
10371039
self.addext(Extension('spwd', ['spwdmodule.c']))
10381040

10391041
# select(2); not on ancient System V
@@ -1254,9 +1256,6 @@ def detect_crypt(self):
12541256

12551257
self.add(Extension('_crypt', ['_cryptmodule.c'], libraries=libs))
12561258

1257-
def detect_socket(self):
1258-
self.add(Extension('_socket', ['socketmodule.c']))
1259-
12601259
def detect_dbm_gdbm(self):
12611260
# Modules that provide persistent dictionary-like semantics. You will
12621261
# probably want to arrange for at least one of them to be available on
@@ -1460,7 +1459,6 @@ def detect_modules(self):
14601459
self.detect_test_extensions()
14611460
self.detect_readline_curses()
14621461
self.detect_crypt()
1463-
self.detect_socket()
14641462
self.detect_openssl_hashlib()
14651463
self.detect_hash_builtins()
14661464
self.detect_dbm_gdbm()

0 commit comments

Comments
 (0)