Skip to content

Rework Argument Clinic error handling #107468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
Tracked by #104683
erlend-aasland opened this issue Jul 30, 2023 · 1 comment
Closed
2 tasks
Tracked by #104683

Rework Argument Clinic error handling #107468

erlend-aasland opened this issue Jul 30, 2023 · 1 comment
Labels
topic-argument-clinic type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jul 30, 2023 •
edited
Loading

Suggesting to...:

  • Introduce ClinicError and ClinicWarning
  • Rework fail to raise a ClinicError, and warn to use warnings.warn(..., ClinicWarning)

This will simplify the test suite (we can use assertRaisesRegex instead of the current capture stdout hacks). Proof-of-concept implementation: Argument-Clinic#2
@erlend-aasland erlend-aasland mentioned this issue Jul 30, 2023
Closed
7 tasks
@erlend-aasland erlend-aasland added type-feature A feature request or enhancement topic-argument-clinic labels Jul 30, 2023
This was referenced Jul 30, 2023
Closed
Open
@erlend-aasland
Copy link
Contributor Author

This was addressed in #107467, #104683. Closing as outdated.

@erlend-aasland erlend-aasland closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-argument-clinic type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erlend-aasland