-
-
Notifications
You must be signed in to change notification settings - Fork 32k
test_uuid leaks references #115725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I modified refleak.py: diff --git a/Lib/test/libregrtest/refleak.py b/Lib/test/libregrtest/refleak.py
index 71a70af688..4921999ccc 100644
--- a/Lib/test/libregrtest/refleak.py
+++ b/Lib/test/libregrtest/refleak.py
@@ -145,7 +145,7 @@ def check_rc_deltas(deltas):
#
# [5, 5, 6]
# [10, 1, 1]
- return all(delta >= 1 for delta in deltas)
+ return any(delta >= 1 for delta in deltas)
def check_fd_deltas(deltas):
return any(deltas) I'm not convinced that it's a leak:
It's just that some objects deletion are delayed to the next iteration: they are many "negative leaks" :-) |
Using my patch, I can reproduce the issue with these 3 patches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Two out of three
test_uuid
runs leak references. This is hidden by theall()
heuristic in regrtest.Output with #115720:
The text was updated successfully, but these errors were encountered: