Skip to content

Colorized output implemented in new REPL leaks into old REPL #119551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eugenetriguba opened this issue May 25, 2024 · 3 comments
Closed

Colorized output implemented in new REPL leaks into old REPL #119551

eugenetriguba opened this issue May 25, 2024 · 3 comments
Labels
3.13 bugs and security fixes type-bug An unexpected behavior, bug, or error

Comments

@eugenetriguba
Copy link
Contributor

eugenetriguba commented May 25, 2024

Bug report

Bug description:

When I run PYTHON_BASIC_REPL=1 ./python.exe from the main branch, the exception output is colorized:

Screenshot 2024-05-25 at 11 50 17

However, this isn't the case using the old REPL on older Python versions:

Screenshot 2024-05-25 at 11 52 38

Whether this is a "bug" can be decided on, but it is different behavior that seemed like it was unintentional to me so I wanted to log it here.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

@eugenetriguba eugenetriguba added the type-bug An unexpected behavior, bug, or error label May 25, 2024
@AlexWaygood AlexWaygood added 3.13 bugs and security fixes topic-repl Related to the interactive shell and removed topic-repl Related to the interactive shell labels May 25, 2024
@AlexWaygood
Copy link
Member

I don't think this is actually anything to do with the REPL per se. I think this is just a consequence of the fact that all tracebacks -- in the REPL or otherwise -- are colourised on Python 3.13+, in a separate feature that has been added

@eugenetriguba
Copy link
Contributor Author

@AlexWaygood Ah I appreciate the additional context there. I wasn't aware of that, thanks! Is this a "close, no issue here" then?

@AlexWaygood
Copy link
Member

I think so, yup! See #112730 for more context :-)

@AlexWaygood AlexWaygood closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants