Skip to content

make memoryview thread safe in free-threading #127716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kumaraditya303 opened this issue Dec 7, 2024 · 4 comments
Open

make memoryview thread safe in free-threading #127716

kumaraditya303 opened this issue Dec 7, 2024 · 4 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-free-threading type-feature A feature request or enhancement

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 7, 2024 •
edited by picnixz
Loading

memoryview is currently not safe against free-threading especially concurrent releasing the memoryviews. This issue track work to make it thread safe.

This is a follow-up to #127412 (review).
@kumaraditya303 kumaraditya303 added interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-free-threading 3.14 bugs and security fixes labels Dec 7, 2024
@kumaraditya303 kumaraditya303 self-assigned this Dec 7, 2024
@picnixz
Copy link
Member

picnixz commented Dec 7, 2024

Do you think it should be a feature (main only) or a bug fix (3.13+)?

@kumaraditya303
Copy link
Contributor Author

For now I'll target main, if it doesn't need too many changes it may be backported.

@picnixz picnixz added type-feature A feature request or enhancement and removed 3.14 bugs and security fixes labels Dec 7, 2024
@picnixz
Copy link
Member

picnixz commented Dec 7, 2024

Ok. I'll apply the labels after we decided whether we should backport it or not.

@ZeroIntensity
Copy link
Member

FWIW, we typically do backport thread safety fixes to 3.13. We should probably merge gh-127412 before putting up anything new to prevent conflicts.

@serhiy-storchaka serhiy-storchaka changed the title make memoryview thread safe in free-theading make memoryview thread safe in free-threading Dec 13, 2024
@kumaraditya303 kumaraditya303 mentioned this issue Dec 16, 2024
Merged
@hawkinsp hawkinsp mentioned this issue Feb 4, 2025
Closed
@kumaraditya303 kumaraditya303 removed their assignment Mar 17, 2025
@ZeroIntensity ZeroIntensity mentioned this issue Apr 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@picnixz @ZeroIntensity @kumaraditya303