Respect the environment variable SVNROOT in external-common.bat

[akruis]

BPO	23160
Nosy	@zware, @zooba, @akruis
Files	issue23160-3.4.diff: Patch for 3.4 issue23160-2.7.diff: Patch for 2.7

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-01-15.17:18:30.514>
created_at = <Date 2015-01-04.07:35:09.878>
labels = ['type-feature', 'build']
title = 'Respect the environment variable SVNROOT in external-common.bat'
updated_at = <Date 2015-01-15.17:18:52.761>
user = 'https://github.com/akruis'

bugs.python.org fields:

activity = <Date 2015-01-15.17:18:52.761>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2015-01-15.17:18:30.514>
closer = 'python-dev'
components = ['Build']
creation = <Date 2015-01-04.07:35:09.878>
creator = 'anselm.kruis'
dependencies = []
files = ['37593', '37594']
hgrepos = []
issue_num = 23160
keywords = ['patch']
message_count = 7.0
messages = ['233395', '233396', '233397', '233558', '233877', '234090', '234091']
nosy_count = 4.0
nosy_names = ['python-dev', 'zach.ware', 'steve.dower', 'anselm.kruis']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23160'
versions = ['Python 2.7', 'Python 3.4']

[akruis]

Issue bpo-21907 introduced the environment variable SVNROOT in
PCbuild/get_externals.bat.

I propose to use the same variable in Tools/buildbot/external-common.bat too. This batch contains many verbatim copies of the SVN-URL.
With the provided patch, it would become much simpler to use a (local) mirror of svn.python.org.

[akruis]

Patch for 3.4

[akruis]

Patch for 2.7

[zooba]

Don't have time to apply them right now, but the patches look fine. I guess it'll null-merge into default, since 3.5 is unaffected?

[akruis]

Your guess is correct, it will be a null merge into default.

[python-dev]

New changeset 294501835890 by Steve Dower in branch '2.7':
Closes bpo-23160: Respect the environment variable SVNROOT in external-common.bat (patch by anselm.kruis)
https://hg.python.org/cpython/rev/294501835890

[python-dev]

New changeset 45e2c95bb802 by Steve Dower in branch '3.4':
Closes bpo-23160: Respect the environment variable SVNROOT in external-common.bat (patch by anselm.kruis)
https://hg.python.org/cpython/rev/45e2c95bb802