Skip to content

Update code taken from Keccak Code Package #87445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
illia-v mannequin opened this issue Feb 20, 2021 · 3 comments
Closed

Update code taken from Keccak Code Package #87445

illia-v mannequin opened this issue Feb 20, 2021 · 3 comments
Labels
3.10 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@illia-v
Copy link
Mannequin

illia-v mannequin commented Feb 20, 2021

BPO 43279
Nosy @tiran, @illia-v
PRs
  • bpo-43279: Update code taken from Keccak Code Package #24601
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-02-20.17:49:15.028>
    labels = ['extension-modules', 'type-feature', '3.10']
    title = 'Update code taken from Keccak Code Package'
    updated_at = <Date 2021-02-20.18:39:57.909>
    user = 'https://github.com/illia-v'

    bugs.python.org fields:

    activity = <Date 2021-02-20.18:39:57.909>
    actor = 'christian.heimes'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2021-02-20.17:49:15.028>
    creator = 'illia-v'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 43279
    keywords = ['patch']
    message_count = 2.0
    messages = ['387422', '387424']
    nosy_count = 2.0
    nosy_names = ['christian.heimes', 'illia-v']
    pr_nums = ['24601']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue43279'
    versions = ['Python 3.10']

    @illia-v
    Copy link
    Mannequin Author

    illia-v mannequin commented Feb 20, 2021

    There were some updates to the Keccak package (https://github.com/XKCP/XKCP) since it was integrated in CPython initially.

    I will submit a pull request soon

    @illia-v illia-v mannequin added 3.10 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Feb 20, 2021
    @tiran
    Copy link
    Member

    tiran commented Feb 20, 2021

    Please hold off. Once PEP-644 gets accepted, I'm going to remove our copy of Keccak and _sha3 module entirely.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @gpshead
    Copy link
    Member

    gpshead commented Nov 7, 2022

    XKCP code was removed, dodging the #98517 bullet for 3.11+. see #91254

    @gpshead gpshead closed this as completed Nov 7, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants