Skip to content

Fix test_shelve and make it discoverable #89665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhiy-storchaka opened this issue Oct 17, 2021 · 5 comments
Closed

Fix test_shelve and make it discoverable #89665

serhiy-storchaka opened this issue Oct 17, 2021 · 5 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 45502
Nosy @ambv, @serhiy-storchaka
PRs
  • bpo-45502: Fix test_shelve #29003
  • [3.10] bpo-45502: Fix test_shelve (GH-29003) #29305
  • [3.9] [3.10] bpo-45502: Fix test_shelve (GH-29003) (GH-29305) #29306
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-10-29.10:19:07.765>
    created_at = <Date 2021-10-17.10:15:57.401>
    labels = ['type-bug', 'tests', '3.9', '3.10', '3.11']
    title = 'Fix test_shelve and make it discoverable'
    updated_at = <Date 2021-10-29.10:19:07.765>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2021-10-29.10:19:07.765>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-10-29.10:19:07.765>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2021-10-17.10:15:57.401>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45502
    keywords = ['patch']
    message_count = 5.0
    messages = ['404133', '404134', '404772', '405295', '405300']
    nosy_count = 2.0
    nosy_names = ['lukasz.langa', 'serhiy.storchaka']
    pr_nums = ['29003', '29305', '29306']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue45502'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @serhiy-storchaka
    Copy link
    Member Author

    test_shelve was intended to run some tests for all underlying dbm implementation, but since b17acad (at May 2008) it runs them with the same implementation.

    The proposed PR fixes this regression and also makes test_shelve discoverable, so it can be run with the unittest module.

    @serhiy-storchaka serhiy-storchaka added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Oct 17, 2021
    @serhiy-storchaka
    Copy link
    Member Author

    Also it was only tested with pickle protocols 0, 1 and 2. Now it will be tested with all pickle protocols.

    @ambv
    Copy link
    Contributor

    ambv commented Oct 22, 2021

    New changeset b781cc3 by Serhiy Storchaka in branch 'main':
    bpo-45502: Fix test_shelve (GH-29003)
    b781cc3

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 6b86702 by Serhiy Storchaka in branch '3.10':
    [3.10] bpo-45502: Fix test_shelve (GH-29003) (GH-29305)
    6b86702

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset a043706 by Serhiy Storchaka in branch '3.9':
    [3.9] [3.10] bpo-45502: Fix test_shelve (GH-29003) (GH-29305) (GH-29306)
    a043706

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants