From fd12e85ff56b0db5d43debe361a1f20a6b13000b Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 26 Sep 2023 02:07:12 +0200 Subject: [PATCH] gh-109401: Fix threading barrier test_default_timeout() (GH-109875) Increase timeouts. Barrier default timeout should be long enough to spawn 4 threads on a slow CI. (cherry picked from commit e5186c3de4194de3ea8c80edb182d786f5e20944) Co-authored-by: Victor Stinner --- Lib/test/lock_tests.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Lib/test/lock_tests.py b/Lib/test/lock_tests.py index a4f52cb20ad301..0890ec87afd1c6 100644 --- a/Lib/test/lock_tests.py +++ b/Lib/test/lock_tests.py @@ -1014,13 +1014,15 @@ def test_default_timeout(self): """ Test the barrier's default timeout """ - # create a barrier with a low default timeout - barrier = self.barriertype(self.N, timeout=0.3) + # gh-109401: Barrier timeout should be long enough + # to create 4 threads on a slow CI. + timeout = 1.0 + barrier = self.barriertype(self.N, timeout=timeout) def f(): i = barrier.wait() if i == self.N // 2: - # One thread is later than the default timeout of 0.3s. - time.sleep(1.0) + # One thread is later than the default timeout. + time.sleep(timeout * 2) self.assertRaises(threading.BrokenBarrierError, barrier.wait) self.run_threads(f)