From 91daa4d4d00d0c54da4d147520be10a14b9fd88f Mon Sep 17 00:00:00 2001 From: Evan Kohilas Date: Sun, 29 Oct 2023 05:26:20 +0000 Subject: [PATCH 1/5] Add aoverage test for number check --- Lib/test/test_capi/test_abstract.py | 5 +++++ Modules/_testcapi/abstract.c | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/Lib/test/test_capi/test_abstract.py b/Lib/test/test_capi/test_abstract.py index eeaef60a8b47b5..6c5f9e31f7033d 100644 --- a/Lib/test/test_capi/test_abstract.py +++ b/Lib/test/test_capi/test_abstract.py @@ -817,6 +817,11 @@ def test_sequence_tuple(self): self.assertRaises(TypeError, xtuple, 42) self.assertRaises(SystemError, xtuple, NULL) + def test_number_check_complex(self): + number_check = _testcapi.number_check + self.assertTrue(number_check(1 + 1j)) + + if __name__ == "__main__": unittest.main() diff --git a/Modules/_testcapi/abstract.c b/Modules/_testcapi/abstract.c index a93477a7090422..4a9144e66f0fcd 100644 --- a/Modules/_testcapi/abstract.c +++ b/Modules/_testcapi/abstract.c @@ -180,6 +180,12 @@ object_delattrstring(PyObject *self, PyObject *args) RETURN_INT(PyObject_DelAttrString(obj, attr_name)); } +static PyObject * +number_check(PyObject *self, PyObject *obj) +{ + NULLABLE(obj); + return PyBool_FromLong(PyNumber_Check(obj)); +} static PyObject * mapping_check(PyObject *self, PyObject *obj) @@ -623,6 +629,7 @@ static PyMethodDef test_methods[] = { {"object_delattr", object_delattr, METH_VARARGS}, {"object_delattrstring", object_delattrstring, METH_VARARGS}, + {"number_check", number_check, METH_O}, {"mapping_check", mapping_check, METH_O}, {"mapping_size", mapping_size, METH_O}, {"mapping_length", mapping_length, METH_O}, From 08c5af94f229b186c4bf28d5e00c61f3fb4ab166 Mon Sep 17 00:00:00 2001 From: "blurb-it[bot]" <43283697+blurb-it[bot]@users.noreply.github.com> Date: Sun, 29 Oct 2023 05:41:48 +0000 Subject: [PATCH 2/5] =?UTF-8?q?=F0=9F=93=9C=F0=9F=A4=96=20Added=20by=20blu?= =?UTF-8?q?rb=5Fit.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst diff --git a/Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst b/Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst new file mode 100644 index 00000000000000..321f1a16b0b258 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst @@ -0,0 +1 @@ +Add a C API test for the PyNumber_Check function. From 9baf4179f63a6e6229a94e45dd0d04417f71e001 Mon Sep 17 00:00:00 2001 From: Evan Kohilas Date: Sun, 29 Oct 2023 08:12:53 +0200 Subject: [PATCH 3/5] Update Lib/test/test_capi/test_abstract.py Co-authored-by: Donghee Na --- Lib/test/test_capi/test_abstract.py | 1 - 1 file changed, 1 deletion(-) diff --git a/Lib/test/test_capi/test_abstract.py b/Lib/test/test_capi/test_abstract.py index 6c5f9e31f7033d..e52f2ff1d93684 100644 --- a/Lib/test/test_capi/test_abstract.py +++ b/Lib/test/test_capi/test_abstract.py @@ -822,6 +822,5 @@ def test_number_check_complex(self): self.assertTrue(number_check(1 + 1j)) - if __name__ == "__main__": unittest.main() From 445bcc0e043cfaa2cc323e308384fcace8fcff9e Mon Sep 17 00:00:00 2001 From: Evan Kohilas Date: Sun, 29 Oct 2023 08:13:03 +0200 Subject: [PATCH 4/5] Update Lib/test/test_capi/test_abstract.py Co-authored-by: Donghee Na --- Lib/test/test_capi/test_abstract.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_capi/test_abstract.py b/Lib/test/test_capi/test_abstract.py index e52f2ff1d93684..ffc41138b38eb5 100644 --- a/Lib/test/test_capi/test_abstract.py +++ b/Lib/test/test_capi/test_abstract.py @@ -819,7 +819,7 @@ def test_sequence_tuple(self): def test_number_check_complex(self): number_check = _testcapi.number_check - self.assertTrue(number_check(1 + 1j)) + self.assertTrue(_testcapi.number_check(1 + 1j)) if __name__ == "__main__": From fd3d99c6192fdb0737b6bae8e76ebe10dbfdd029 Mon Sep 17 00:00:00 2001 From: Evan Kohilas Date: Sun, 29 Oct 2023 08:13:11 +0200 Subject: [PATCH 5/5] Update Lib/test/test_capi/test_abstract.py Co-authored-by: Donghee Na --- Lib/test/test_capi/test_abstract.py | 7 +++++-- .../Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst | 1 - 2 files changed, 5 insertions(+), 3 deletions(-) delete mode 100644 Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst diff --git a/Lib/test/test_capi/test_abstract.py b/Lib/test/test_capi/test_abstract.py index ffc41138b38eb5..687ce1e6376814 100644 --- a/Lib/test/test_capi/test_abstract.py +++ b/Lib/test/test_capi/test_abstract.py @@ -817,9 +817,12 @@ def test_sequence_tuple(self): self.assertRaises(TypeError, xtuple, 42) self.assertRaises(SystemError, xtuple, NULL) - def test_number_check_complex(self): + def test_number_check(self): number_check = _testcapi.number_check - self.assertTrue(_testcapi.number_check(1 + 1j)) + self.assertTrue(number_check(1 + 1j)) + self.assertTrue(number_check(1)) + self.assertTrue(number_check(0.5)) + self.assertFalse(number_check("1 + 1j")) if __name__ == "__main__": diff --git a/Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst b/Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst deleted file mode 100644 index 321f1a16b0b258..00000000000000 --- a/Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst +++ /dev/null @@ -1 +0,0 @@ -Add a C API test for the PyNumber_Check function.