gh-95273: Improve sqlite3 class descriptions #95379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
added
needs backport to 3.10
bedevere-bot
added
awaiting core review
docs
Contributor
Author
|
I'm not satisfied with the connection and cursor wordings, but this is as far as I could get. I've borrowed slightly from the SQLite docs and PEP 249. |
erlend-aasland
commented
Jul 28, 2022
erlend-aasland
commented
Jul 28, 2022
This was referenced Jul 28, 2022
CAM-Gerlach
reviewed
Jul 29, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
A handful of minor comments, but otherwise LGTM—thanks, @erlend-aasland
Contributor
Author
|
I've addressed all review comments; will land as soon as the CI is green. |
erlend-aasland
commented
Jul 29, 2022
erlend-aasland
commented
Jul 29, 2022
Contributor
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-95425 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2022
Co-authored-by: CAM Gerlach <[email protected]> (cherry picked from commit e003b64) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2022
Co-authored-by: CAM Gerlach <[email protected]> (cherry picked from commit e003b64) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-95426 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: CAM Gerlach <[email protected]> (cherry picked from commit e003b64) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: CAM Gerlach <[email protected]> (cherry picked from commit e003b64) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.