Mostly address review

Author: AlexWaygood

mypy/plugins/dataclasses.py

@@ -338,9 +338,9 @@ def collect_attributes(self) -> Optional[List[DataclassAttribute]]:
                 ctx.api.fail(
                     (
                         'Type aliases inside dataclass definitions '
-                        'are not supported at runtime.'
+                        'are not supported at runtime'
                     ),
-                    Context(line=node.line, column=node.column)
+                    node
                 )
                 # Now do our best to simulate the runtime,
                 # which treates a TypeAlias definition in a dataclass class
@@ -355,14 +355,9 @@ def collect_attributes(self) -> Optional[List[DataclassAttribute]]:
                 # Something else -- fallback to Any
                 else:
                     var_type = AnyType(TypeOfAny.from_error)
-                var = Var(name=fullname, type=var_type)
+                var = Var(name=node.name, type=var_type)
                 var.info = cls.info
                 var._fullname = fullname
-                cls.info.names[fullname] = SymbolTableNode(
-                    kind=MDEF,
-                    node=var,
-                    plugin_generated=True,
-                )
                 sym.node = node = var
 
             assert isinstance(node, Var)

test-data/unit/check-dataclasses.test

@@ -525,7 +525,7 @@ class Foo:
 
 @dataclass
 class One:
-    S: TypeAlias = Foo  # E: Type aliases inside dataclass definitions are not supported at runtime.
+    S: TypeAlias = Foo  # E: Type aliases inside dataclass definitions are not supported at runtime
 
 a = One()
 b = One(Foo)
@@ -537,7 +537,7 @@ reveal_type(b.S(98))  # N: Revealed type is "__main__.Foo"
 
 @dataclass
 class Two:
-    S: TypeAlias = Callable[[int], str]  # E: Type aliases inside dataclass definitions are not supported at runtime.
+    S: TypeAlias = Callable[[int], str]  # E: Type aliases inside dataclass definitions are not supported at runtime
 
 c = Two()
 reveal_type(c.S)  # N: Revealed type is "Any"