Skip to content

Commit ca28425

Browse files
Fix get_member_expr_fullname returning strings with embedded "None" (#17848)
Fixes #17847 ### Before ```python from mypy.nodes import CallExpr, MemberExpr, NameExpr, get_member_expr_fullname m3 = MemberExpr(MemberExpr(CallExpr(NameExpr("a"), [], [], []), "b"), "c") # a().b.c >>> get_member_expr_fullname(m3) 'None.c' ``` ### After ```python from mypy.nodes import CallExpr, MemberExpr, NameExpr, get_member_expr_fullname m3 = MemberExpr(MemberExpr(CallExpr(NameExpr("a"), [], [], []), "b"), "c") # a().b.c >>> get_member_expr_fullname(m3) is None True ```
1 parent 26a77f9 commit ca28425

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mypy/nodes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4090,7 +4090,7 @@ def get_member_expr_fullname(expr: MemberExpr) -> str | None:
40904090
initial = expr.expr.name
40914091
elif isinstance(expr.expr, MemberExpr):
40924092
initial = get_member_expr_fullname(expr.expr)
4093-
else:
4093+
if initial is None:
40944094
return None
40954095
return f"{initial}.{expr.name}"
40964096

0 commit comments

Comments
 (0)