Add tests for new semantic analyzer on older Python (#6640)

This also fixes minor issues found by tests

Author: ilevkivskyi

.travis.yml

@@ -22,6 +22,13 @@ jobs:
     python: 3.6    # 3.6.3  pip  9.0.1
   - name: "run test suite with python 3.7"
     python: 3.7    # 3.7.0  pip 10.0.1
+  - name: "run test suite with python 3.5.1 (new semantic analyzer)"
+    python: 3.5.1
+    dist: trusty
+    env:
+    - TOXENV=py
+    - EXTRA_ARGS="-n 12"
+    - NEWSEMANAL=1
   - name: "run test suite with python 3.7 (new semantic analyzer)"
     python: 3.7
     env:

mypy/newsemanal/semanal_main.py

@@ -182,7 +182,11 @@ def process_functions(graph: 'Graph', scc: List[str], patches: Patches) -> None:
         tree = graph[module].tree
         assert tree is not None
         analyzer = graph[module].manager.new_semantic_analyzer
-        targets = get_all_leaf_targets(tree)
+        # In principle, functions can be processed in arbitrary order,
+        # but _methods_ must be processed in the order they are defined,
+        # because some features (most notably partial types) depend on
+        # order of definitions on self.
+        targets = sorted(get_all_leaf_targets(tree), key=lambda x: x[1].line)
         for target, node, active_type in targets:
             assert isinstance(node, (FuncDef, OverloadedFuncDef, Decorator))
             process_top_level_function(analyzer,

mypy/server/aststripnew.py

@@ -10,7 +10,7 @@
     FuncDef, NameExpr, MemberExpr, RefExpr, MypyFile, ClassDef, AssignmentStmt,
     ImportFrom, CallExpr, Decorator, OverloadedFuncDef, Node, TupleExpr, ListExpr,
     SuperExpr, IndexExpr, ImportAll, ForStmt, Block, CLASSDEF_NO_INFO, TypeInfo,
-    StarExpr, Var
+    StarExpr, Var, SymbolTableNode
 )
 from mypy.traverser import TraverserVisitor
 from mypy.types import CallableType
@@ -87,7 +87,9 @@ def prepare_implicit_var_patches(self, node: ClassDef) -> None:
             if isinstance(sym.node, Var) and sym.implicit:
                 explicit_self_type = sym.node.explicit_self_type
 
-                def patch() -> None:
+                # These arguments should not be passed, we just want to capture
+                # the names in closure at current iteration in the for-loop.
+                def patch(name: str = name, sym: SymbolTableNode = sym) -> None:
                     existing = node.info.get(name)
                     defined_in_this_class = name in node.info.names
                     # This needs to mimic the logic in SemanticAnalyzer.analyze_member_lvalue()