Skip to content

Don't use non-generic tuple etc. in stubs #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JukkaL opened this issue May 3, 2017 · 0 comments
Open

Don't use non-generic tuple etc. in stubs #3309

JukkaL opened this issue May 3, 2017 · 0 comments
Labels
priority-1-normal refactoring Changing mypy's internals topic-tests

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented May 3, 2017

Many test fixtures use class tuple: pass or similar for list/dict (there may be others) even though these classes should be generic. If the corresponding Instance isn't generic, mypy may crash in some cases. We'd like to be able to assert that these are always generic without breaking tests. We should update the fixtures to make these always generic.

More discussion at #3305.
@JukkaL JukkaL added priority-1-normal refactoring Changing mypy's internals labels May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-normal refactoring Changing mypy's internals topic-tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JukkaL @ilevkivskyi