Skip to content

Class typevars lose information from isinstance checks #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msullivan opened this issue Oct 3, 2018 · 1 comment
Open

Class typevars lose information from isinstance checks #5720

msullivan opened this issue Oct 3, 2018 · 1 comment
Labels
bug mypy got something wrong false-positive mypy gave an error on correct code priority-1-normal

Comments

@msullivan
Copy link
Collaborator

from typing import Generic, TypeVar

T = TypeVar('T')

class C(Generic[T]):
    def foo(self, x: T) -> None:
        if isinstance(x, int):
            self.bar(x)

    def bar(self, x: T) -> None:
        pass

fails with Argument 1 to "bar" of "C" has incompatible type "int"; expected "T", even though x is obviously a T (that was its annotated type!)

Arguably this is just the Dreaded Intersection Bug (#3603) in a different manifestation?

@msullivan msullivan added bug mypy got something wrong false-positive mypy gave an error on correct code labels Oct 3, 2018
@ilevkivskyi
Copy link
Member

Yes, and this is probably a hardest aspect of the problem, because I don't see an easy way to work around this using some fake TypeInfos for intersections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong false-positive mypy gave an error on correct code priority-1-normal
Projects
None yet
Development

No branches or pull requests

2 participants