Skip to content

Traverse module ancestors when traversing reachable graph nodes during dmypy update #18906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025
Merged

Traverse module ancestors when traversing reachable graph nodes during dmypy update #18906

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f8fd6a
Traverse module ancestors when traversing reachable graph nodes durin…
sterliakov Apr 10, 2025
1e716bb
Add a reproducible testcase. Sorry, I do not see the exact reason why…
sterliakov Apr 11, 2025
3734d27
Add a comment to mention `seen` role in deleted modules detection
sterliakov Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/dmypy_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,8 @@ def find_reachable_changed_modules(
changed.append((nxt.module, nxt.path))
elif nxt.module in graph:
state = graph[nxt.module]
for dep in state.dependencies:
ancestors = state.ancestors or []
for dep in state.dependencies + ancestors:
if dep not in seen:
seen.add(dep)
worklist.append(BuildSource(graph[dep].path, graph[dep].id, followed=True))
Expand Down