New semantic analyzer: fix access to imported name in class body #6943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't use the line number of an imported name to decide whether it's defined when the line number refers to another file.
ilevkivskyi
approved these changes
Jun 6, 2019
mypy/newsemanal/semanal.py
Outdated
| """ | ||
| return (node is None | ||
| or node.line < self.statement.line | ||
| or not self.is_defined_in_current_module(node) |
There was a problem hiding this comment.
But what if the import happens after the point where imported name is used? Will it cause a false negative? If no, then I would add a test, otherwise maybe open a follow-up issue (or a TODO comment)?
There was a problem hiding this comment.
Added TODO comment. The problem seems minor enough that it's not worth creating an issue.
mypy/newsemanal/semanal.py
Outdated
| or not self.is_defined_in_current_module(node) | ||
| or isinstance(node, TypeInfo)) | ||
|
|
||
| def is_defined_in_current_module(self, node: SymbolNode) -> bool: |
There was a problem hiding this comment.
It looks like this duplicates the functionality of is_local_name(), should we just replace it? There is only one place where it is used in already_defined().
There was a problem hiding this comment.
The behavior is different for short names, but I updated is_local_name to call this.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
…hon#6943) We shouldn't use the line number of an imported name to decide whether it's defined when the line number refers to another file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't use the line number of an imported name to decide
whether it's defined when the line number refers to another
file.