-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Description-Content-Type does not appear to be in accepted PEPs #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ncoghlan suggested that this field does not need to be defined in a PEP -- see https://mail.python.org/pipermail/distutils-sig/2016-June/029078.html |
Thanks. |
To be completely clear, there is open work to be done in this area:
It's just meta-process work to make the process change clearer (including adding a cross-reference to the new home from PEP 345), rather than defining a new iteration of the metadata using the current process. |
So I take it that https://packaging.python.org/specifications/ is the canonical source of valid field names? Is somebody going to update the JSON schema for packaging metadata? Wheel's test suite started failing the moment this new field was introduced by a new setuptools release. How can we prevent this from happening in the future? |
Specifically this file here: https://github.com/python/peps/blob/master/pep-0426/pydist-schema.json |
PEP 426 isn't released yet - the metadata.json file defined by |
Speaking of which – what's currently blocking that PEP? |
A credible belief on my part that it actually solves a real world problem in a way that will prompt people to invest their time and energy in implementing (I should really put it back to Deferred status on those grounds). Specifically, I think we're likely to be better off just adding a command to |
If that is the case, should wheel be writing that data to .dist-info in the first place, as it does now? |
Yes, projects are allowed to write arbitrary files to dist-info (that's by design). wheel calls it metadata.json because we've promised never to use that for any of the formal packaging specifications. |
@ncoghlan Without a PEP defining the new fields, how do we figure out what metadata version supports them? |
@tseaver My interpretation of the following line in the PyPA spec is that these fields are to be a continuation of version 1.2:
However I agree that it's not immediately clear -- I struggled with the same issue when making the I'd be happy to make a clarification to |
@tseaver Feature detection - since readers are supposed to ignore-but-preserve fields they don't understand, publishers should be able to add the new fields without breaking anything (even in metadata 1.2). However, I'm also thinking it may be worth doing a metadata 1.3 specifically to make all this clearer: https://mail.python.org/pipermail/distutils-sig/2017-September/031465.html |
The PEP has now been accepted. |
This field, used in PKG-INFO is now in production use despite not being defined in a PEP. Someone should take this up.
The text was updated successfully, but these errors were encountered: