Skip to content

Commit 6e985ef

Browse files
authored
stdlib mapping classes: Use better names for various pos-only parameters (#8637)
1 parent 1b6cda8 commit 6e985ef

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

stdlib/_typeshed/__init__.pyi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,16 +115,16 @@ class SupportsItems(Protocol[_KT_co, _VT_co]):
115115
# stable
116116
class SupportsKeysAndGetItem(Protocol[_KT, _VT_co]):
117117
def keys(self) -> Iterable[_KT]: ...
118-
def __getitem__(self, __k: _KT) -> _VT_co: ...
118+
def __getitem__(self, __key: _KT) -> _VT_co: ...
119119

120120
# stable
121121
class SupportsGetItem(Container[_KT_contra], Protocol[_KT_contra, _VT_co]):
122-
def __getitem__(self, __k: _KT_contra) -> _VT_co: ...
122+
def __getitem__(self, __key: _KT_contra) -> _VT_co: ...
123123

124124
# stable
125125
class SupportsItemAccess(SupportsGetItem[_KT_contra, _VT], Protocol[_KT_contra, _VT]):
126-
def __setitem__(self, __k: _KT_contra, __v: _VT) -> None: ...
127-
def __delitem__(self, __v: _KT_contra) -> None: ...
126+
def __setitem__(self, __key: _KT_contra, __value: _VT) -> None: ...
127+
def __delitem__(self, __key: _KT_contra) -> None: ...
128128

129129
StrPath: TypeAlias = str | PathLike[str] # stable
130130
BytesPath: TypeAlias = bytes | PathLike[bytes] # stable

stdlib/builtins.pyi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,9 +1059,9 @@ class dict(MutableMapping[_KT, _VT], Generic[_KT, _VT]):
10591059
@overload
10601060
def pop(self, __key: _KT, __default: _VT | _T) -> _VT | _T: ...
10611061
def __len__(self) -> int: ...
1062-
def __getitem__(self, __k: _KT) -> _VT: ...
1063-
def __setitem__(self, __k: _KT, __v: _VT) -> None: ...
1064-
def __delitem__(self, __v: _KT) -> None: ...
1062+
def __getitem__(self, __key: _KT) -> _VT: ...
1063+
def __setitem__(self, __key: _KT, __value: _VT) -> None: ...
1064+
def __delitem__(self, __key: _KT) -> None: ...
10651065
def __iter__(self) -> Iterator[_KT]: ...
10661066
if sys.version_info >= (3, 8):
10671067
def __reversed__(self) -> Iterator[_KT]: ...

stdlib/multiprocessing/managers.pyi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ class ValueProxy(BaseProxy, Generic[_T]):
6868
class DictProxy(BaseProxy, MutableMapping[_KT, _VT]):
6969
__builtins__: ClassVar[dict[str, Any]]
7070
def __len__(self) -> int: ...
71-
def __getitem__(self, __k: _KT) -> _VT: ...
72-
def __setitem__(self, __k: _KT, __v: _VT) -> None: ...
73-
def __delitem__(self, __v: _KT) -> None: ...
71+
def __getitem__(self, __key: _KT) -> _VT: ...
72+
def __setitem__(self, __key: _KT, __value: _VT) -> None: ...
73+
def __delitem__(self, __key: _KT) -> None: ...
7474
def __iter__(self) -> Iterator[_KT]: ...
7575
def copy(self) -> dict[_KT, _VT]: ...
7676
@overload

stdlib/types.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ class CodeType:
304304
class MappingProxyType(Mapping[_KT, _VT_co], Generic[_KT, _VT_co]):
305305
__hash__: ClassVar[None] # type: ignore[assignment]
306306
def __init__(self, mapping: SupportsKeysAndGetItem[_KT, _VT_co]) -> None: ...
307-
def __getitem__(self, __k: _KT) -> _VT_co: ...
307+
def __getitem__(self, __key: _KT) -> _VT_co: ...
308308
def __iter__(self) -> Iterator[_KT]: ...
309309
def __len__(self) -> int: ...
310310
def copy(self) -> dict[_KT, _VT_co]: ...

stdlib/typing.pyi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ class Mapping(Collection[_KT], Generic[_KT, _VT_co]):
576576
# TODO: We wish the key type could also be covariant, but that doesn't work,
577577
# see discussion in https://github.com/python/typing/pull/273.
578578
@abstractmethod
579-
def __getitem__(self, __k: _KT) -> _VT_co: ...
579+
def __getitem__(self, __key: _KT) -> _VT_co: ...
580580
# Mixin methods
581581
@overload
582582
def get(self, __key: _KT) -> _VT_co | None: ...
@@ -589,9 +589,9 @@ class Mapping(Collection[_KT], Generic[_KT, _VT_co]):
589589

590590
class MutableMapping(Mapping[_KT, _VT], Generic[_KT, _VT]):
591591
@abstractmethod
592-
def __setitem__(self, __k: _KT, __v: _VT) -> None: ...
592+
def __setitem__(self, __key: _KT, __value: _VT) -> None: ...
593593
@abstractmethod
594-
def __delitem__(self, __v: _KT) -> None: ...
594+
def __delitem__(self, __key: _KT) -> None: ...
595595
def clear(self) -> None: ...
596596
@overload
597597
def pop(self, __key: _KT) -> _VT: ...

0 commit comments

Comments
 (0)