Skip to content

Add _interpreters to stdlib #12011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tonybaloney opened this issue May 23, 2024 · 7 comments
Closed

Add _interpreters to stdlib #12011

tonybaloney opened this issue May 23, 2024 · 7 comments
Labels
stubs: incomplete Annotations or sub-modules missing from an existing package or module

Comments

@tonybaloney
Copy link

The _interpreters and _interpchannels packages were added in 3.13b1 but are missing type annotations.

Related #11990

I'd be happy to submit these sometime over the next week in a PR
@tonybaloney
Copy link
Author

Cc @ericsnowcurrently

@srittau srittau added the stubs: incomplete Annotations or sub-modules missing from an existing package or module label May 23, 2024
@max-muoto
Copy link
Contributor

Have started to work on these, I'd imagine I'll have a PR up in the coming days.

@AlexWaygood
Copy link
Member

It might be easier to review if we first added some generated stubs using stubgen (if possible, using our wrapper script scripts/create_baseline_stubs.py), and we then incrementally made improvements to the generated stubs

@tonybaloney
Copy link
Author

Does stubgen use dir()? _interpreters is purely a C extension

@AlexWaygood
Copy link
Member

Stubgen is able to introspect C extensions, yup (see https://github.com/python/mypy/blob/master/mypy/stubgenc.py for the implementation)

@max-muoto
Copy link
Contributor

Put up a first PR for _interpchannels: #12199

@max-muoto
Copy link
Contributor

We can close this out now @srittau.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: incomplete Annotations or sub-modules missing from an existing package or module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@srittau @JelleZijlstra @tonybaloney @max-muoto @AlexWaygood and others